Skip to content

Conversation

DavidKorczynski
Copy link
Collaborator

No description provided.

@DavidKorczynski
Copy link
Collaborator Author

@tsdgeos do you approve?

Signed-off-by: David Korczynski <[email protected]>
@tsdgeos
Copy link
Contributor

tsdgeos commented Jul 6, 2025

Is this another occasion of #13289 happening?

I can't even see a build failure in https://issues.oss-fuzz.com/issues?q=poppler%20status:open

Where can i find the build failure log?

Aren't both functions declared in the same header?

tsdgeos@xps15:/usr/include/glib-2.0:$ wcgrep g_sort_array
./glib/gqsort.h:46:void g_sort_array (const void *array,

tsdgeos@xps15:/usr/include/glib-2.0:$ wcgrep g_qsort_with_data
./glib/gqsort.h:39:void g_qsort_with_data (gconstpointer pbase,

@DavidKorczynski now that i have your attention can we get #13435 merged please?

@DavidKorczynski
Copy link
Collaborator Author

Here are the build logs: https://oss-fuzz-build-logs.storage.googleapis.com/index.html#poppler

Am not entirely sure why it's not showing up on issues.oss-fuzz.com -- @oliverchang @jonathanmetzman

Looking at the logs, it looks like the most recent one is complaining about some ASAN issues, which I believe is different to the fix from here. I'll need to double check if this is only an issue in honggfuzz.

@DavidKorczynski
Copy link
Collaborator Author

@tsdgeos I see that poppler is still failing -- are you happy with landing this?

@tsdgeos
Copy link
Contributor

tsdgeos commented Oct 12, 2025

@DavidKorczynski sure i guess.

Would be great to use a newer version to build but pango is not super critical in poppler's dependency chain so i guess it's fine until someone has time to figure out what's going on.

Thanks for the ping :)

@AdamKorcz AdamKorcz merged commit 3de6704 into master Oct 13, 2025
15 checks passed
@AdamKorcz AdamKorcz deleted the poppler-fix-build branch October 13, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants